Skip to content

Azure: Enable CAPZ CCM e2e by default#22079

Merged
k8s-ci-robot merged 2 commits into
kubernetes:masterfrom
CecileRobertMichon:capz-oot
May 5, 2021
Merged

Azure: Enable CAPZ CCM e2e by default#22079
k8s-ci-robot merged 2 commits into
kubernetes:masterfrom
CecileRobertMichon:capz-oot

Conversation

@CecileRobertMichon
Copy link
Copy Markdown
Member

@CecileRobertMichon CecileRobertMichon commented May 4, 2021 •
edited
Loading

/hold until kubernetes-sigs/cluster-api-provider-azure#1330 merges

Enabled the job to run by default, still optional for now.

Removed K8S_AZURE_LOADBALANCE_SKU variable since kubernetes-sigs/cloud-provider-azure#599 has merged.

/assign @feiskyer @chewong

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 4, 2021
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and khenidak May 4, 2021 18:40
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 4, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2021
@dims
Copy link
Copy Markdown
Member

dims commented May 4, 2021

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021
chewong
chewong reviewed May 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CecileRobertMichon
Copy link
Copy Markdown
Member Author

CecileRobertMichon commented May 5, 2021

/hold cancel
/assign @nilo19

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2021
@nilo19
Copy link
Copy Markdown
Member

nilo19 commented May 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2af8266 into kubernetes:master May 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 5, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 5, 2021

@CecileRobertMichon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-azure-config.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml
  • key cloud-provider-azure-presubmit-0.7.yaml using file config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-presubmit-0.7.yaml
Details

In response to this:

/hold until kubernetes-sigs/cluster-api-provider-azure#1330 merges

Enabled the job to run by default, still optional for now.

Removed K8S_AZURE_LOADBALANCE_SKU variable since kubernetes-sigs/cloud-provider-azure#599 has merged.

/assign @feiskyer @chewong

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@khenidak khenidak Awaiting requested review from khenidak

1 more reviewer

@chewong chewong chewong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@feiskyer feiskyer

@chewong chewong

@nilo19 nilo19

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

6 participants

@CecileRobertMichon @dims @k8s-ci-robot @nilo19 @chewong @feiskyer